Repository navigation
Conversation
…l ruleset
- Remove the bogus unconditional $p1_0 = "RIFF" disjunct in taxonomy_webp
that caused it to match every RIFF container (wav, avi, ani).
- Require the 16-byte Google WebP Container Specification header at offset 0
("RIFF" + 4-byte size + "WEBP" + initial chunk FourCC "VP8 ", "VP8L", or "VP8X").
- Promote taxonomy_webp from notworking/formats.yar to full/formats.yar
(100/100 = 100.0% recall on webp, 0 false positives across 44,681 negative files).
- Regenerate rust/rules/src/bundled.rs, rust/gen/rules/content_types,
assets/content_types_kb.min.json, and rust/lib/src/content.rs.
ia0
approved these changes
Oct 21, 2026
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay, the email got lost.
I'll send a PR to make you owner of the YARA files too (in addition to files generated from them).
Member
|
I've sent #1554 |
Collaborator
Author
|
closing, rules are going away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust/rules/rulesets/notworking/formats.yar,rule taxonomy_webpwas quarantined (enforced = false,class = "not-working",fp_rate = 0.010196) because a translatedpuremagicmulti-part header check joined$p0_0 = { 52 49 46 46 ?? ?? ?? ?? 57 45 42 50 }withor ($p1_0 at 0)where$p1_0 = "RIFF", causing it to match every RIFF container (wav,avi,ani, etc.).$p1_0 = "RIFF"disjunct, require the 16-byte Google WebP Container Specification header at offset0("RIFF"at0..4,"WEBP"at8..12, and initial chunk FourCC"VP8 ","VP8L", or"VP8X"at12..16), and promotetaxonomy_webptorust/rules/rulesets/full/formats.yar(enforced = true,class = "full",fp_rate = 0,fn_rate = 0).rust/rules/src/bundled.rs,rust/gen/rules/content_types,assets/content_types_kb.min.json(scripts/sync_kb.py), andrust/lib/src/content.rs(rust/gen).Verification
44,781exported files):100 / 100(100.00%) recall onwebpand0false positives across all44,681negative files.cargo testinrust/rules(75 tests) andcargo test --libinrust/lib(9 tests) pass.scripts/sync_kb.py --checkand--self-test(33/33) pass.