Repository navigation
Add back OverwriteReason - #1549
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors how model prediction overwrite reasons are handled and exposed. It introduces an OverwriteReason enum (with variants LowConfidence, OverwriteMap, and RulesVeto) in the library, stores this reason in ModelDebugInfo, and updates the CLI, Python bindings, and tests to consume this structured information directly instead of recalculating it. Feedback is provided regarding the use of let-chains (&& let) in rust/cli/src/main.rs, which is an unstable Rust feature and will fail to compile on stable Rust compilers; it should be rewritten using stable combinators like and_then and map.
reyammer
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.