Repository navigation
Conversation
This was referenced Oct 8, 2026
Member
Author
|
Closing in favor of #1530 which contains this change. |
1 of 7 tasks
ebursztein
added a commit
that referenced
this pull request
Oct 9, 2026
The GPU qualification test only compiles on macOS or with CUDA, so CI did not see that it still used Features.0 and the old FileType::convert signature. It now passes the options, with rules off since the reference outputs are the model's alone, and maps RulesVeto as unreachable.
ebursztein
added a commit
that referenced
this pull request
Oct 9, 2026
Features extracted with use_rules = false recorded an empty list of matching rules, so a session with rules on vetoed every prediction whose rules have no false negatives: real WAV, PSD, Parquet and XLSX files came out unknown. Features now record None when the rules did not run, and the veto needs evidence that they ran and did not match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds support for ZIP (otherwise rules would veto ZIP without reading the tail).
This doesn't add "debugging" information to
FileTypeyet. This will be done later. This PR is about functionality only (not final API).