Repository navigation
Possible memory leak: model path C.CString is never freed in NewOnnx #1444
Description
Activity
I verified the
C.CString(modelPath)allocation is still passed inline on currentmain, so it has no correspondingC.freeon either return path. I’ll send a focused PR that binds and frees only that Go-owned C string; the separate ONNX environment/options/status cleanup should remain separate work.Thanks for picking this up. #1446 matches what I reported: it binds the
conversion and defers the free, so both the error return and the success return
release it.cModelPath := C.CString(modelPath) defer C.free(unsafe.Pointer(cModelPath))
Agreed on keeping the ONNX environment, session options and
OrtStatuscleanup
separate, they are a different ownership question.The PR is still open at the time of writing, so leaving this issue open until it
lands seems right.
Possible memory leak: model path C.CString is never freed in NewOnnx
NewOnnxpasses the model path toCreateSessionas an inlineC.CString. Theallocation is not bound to a variable, so there is no name available to free it
afterwards.
go/onnx/onnx_runtime.go:21
go/onnx/onnx_runtime.h:15
modelis taken asconst char *and handed toOrtApi::CreateSession, whichcopies the path. Nothing takes ownership of the buffer, and
CreateSessiondoesnot free it, so the string leaks on every call, on both the success and the
error path.
Fix:
with
#include <stdlib.h>in the preamble.Separately,
RETURN_ON_ERRORinCreateSessionreturns before releasingenvand
options, and theOrtStatusreturned to Go is never passed toReleaseStatus.If you could credit me as a reporter for my contributions to security advisory I will be thankful.