Repository navigation
Conversation
4 of 72 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive documentation for Open Foris Collect One, detailing its product requirements, integration with Collect Earth Online, terminology parity, XForms integration, and impact measurement framework. The documentation is well-structured and thorough. The review feedback highlights a few minor areas for improvement, including correcting a typo ('exclusivamente' to 'exclusively'), standardizing punctuation and placeholder brackets, ensuring consistent naming for 'FAO GEF 7', and refining some awkward phrasing in the XForms integration guide.
gino-m
added a commit
that referenced
this pull request
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect One review series: D1 Docs: product & UX (2/60)
Tracking issue: #2629 · Stacked on:
c1(C01 #2630 merged) · Reviewer: @rfontanarosaFYI: @gino-m @shobhitagarwal1612
Context
Collect One is the Kotlin Multiplatform successor to Ground: a single shared codebase for the web console, the mobile app (Android, iOS, browser), and a Spanner-backed user-data service. Forms use ProtoForms, a lossless proto3 encoding of ODK XForms.
This PR is one slice of the frozen
wip/baobabtree (collect-one-review-base), landing through 60 stacked PRs intoc1(see #2629). It adds the core product specifications, partner integration architecture, terminology lexicon, and UX guidelines. Stacked onc1(now that C01 #2630 is merged), so the diff shows only this slice.What's in this PR
docs/README.md: Index of Collect One architecture, design specs, and data model documentation across product, technical, and UX sections; core mental model (Entity-only map, 1-Form-to-1-Entity provisioning, live schema sync).docs/product/prd.md: Comprehensive Product Requirements Document covering mission, multiplatform reach (Web, Android, iOS), desk-to-field loop uniting CEO and Ground, XLSForm/ODK Entities compliance, feature matrix, and functional requirements.docs/product/concept-brief.md: Executive summary of why FAO, SIG, and Google are uniting Ground and CEO; problem statement, target personas, scope boundaries, and institutional roles.docs/product/ceo-integration.md: Collect Earth Online functional inventory and desk-to-field plot flagging architecture (multi-temporal satellite visual interpretation, blind consensus QA/QC, high-uncertainty field routing).docs/product/xforms-integration.md: XForms and ODK Entities integration architecture; the Entity-only map model, default 1-Form-to-1-Entity provisioning, and automaticsave_toschema synchronization.docs/product/terminology.md: Master terminology lexicon and cross-platform parity matrix across Collect One, Collect Earth Online, ODK Central/Collect, KoboToolbox, XLSForm, ArcGIS Survey123, and Open Foris Arena.docs/product/impact-measurement.md: Proposed MAP (Mitigation, Adaptation, Protection) impact measurement approach with minimal field burden (Purpose Packs, semantic indicator tags, spatial overlays, outcome events, partner ledgers, and attribution rubric).docs/product/impacts.md: Global impact analysis, deployment case studies, and field metrics across Ghana, Burundi, Kenya, and Viet Nam.docs/product/website-outline.md: Public documentation and portal structure.docs/product/future-work.md: Extensibility roadmap, future integrations, and post-C1 evolution.docs/ux/content-guidelines.md: UX writing standards, voice and tone, domain terminology, and content principles for user-facing copy.Where it fits
Foundational product and architectural reference for the entire repository. Later slices—protos (P1–P3), core engine (K1–K7), UI (U1–U2), server (S1–S4), web (W1–W10), mobile (MB1–MB2), and hosts (H1–H3)—implement the data models, workflows, and terminology defined here.
Not in this PR
Suggested reading order
docs/product/concept-brief.md(orientation and institutional partnership)docs/product/prd.md(complete product requirements and platform capabilities)docs/product/xforms-integration.mdanddocs/product/terminology.md(core mental model and terminology mapping)docs/product/ceo-integration.md(desk-to-field workflow loop)docs/ux/content-guidelines.mdanddocs/product/impact-measurement.mdFocus areas
xforms-integration.md): does this cleanly bridge simple surveys with longitudinal multi-visit monitoring?terminology.md): does the cross-platform parity matrix accurately align with ODK, XLSForm, CEO, and Arena conventions?ceo-integration.md): clarity of the handoff between satellite visual interpretation and offline ground verification.Safe to skim
docs/product/website-outline.mdanddocs/product/future-work.md(introductory portal outline and future roadmap)Size
Testing
Docs only. Verified formatting and licenses via
./c1q.py verify D1(ktfmt: PASS, license: PASS). CI:check(ktfmt, buf).Checked for published monetary amounts (
git grep -nE '(\$|€|£|USD|EUR) ?[0-9]'): 0 occurrences found.