Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up make dev by leveraging opam's with-dev-setup flag instead of manually installing ocaml-lsp-server and ocp-indent separately. Dev-setup dependencies are now declared in dune-project / goblint.opam, making the dev installation a single opam invocation.
Changes:
- Add
ocaml-lsp-serverandocp-indentaswith-dev-setupdependencies indune-projectandgoblint.opam. - Simplify
make.shdevtarget to a singleopam installcall using--with-dev-setup.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| make.sh | Replace two-step dev install with a single opam install using --with-dev-setup. |
| goblint.opam | Declare ocaml-lsp-server and ocp-indent under with-dev-setup. |
| dune-project | Mirror the dev-setup dependency declarations with explanatory comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
opam lock seems to drop constraints if there are multiple reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleaner alternative to #2031.
TODO