fix: escape quoted-string metacharacters in digest-md5 response#595
Merged
cpuschma merged 1 commit intoJun 9, 2026
Merged
Conversation
cpuschma
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeResponsewritesusername,realm,nonceanddigest-uristraight into the quoted-string directives of the digest-response without escaping\and", which RFC 2831 section 7.1 requires for a quoted string."in the username (application supplied) or in the server-supplied realm/nonce that gets echoed back closes the directive early and injects extra directives into the SASL credential, e.g. usernamea",realm="xyields a secondrealm=in the response.quotedStringEscapeand applied it to each quoted value. The digest is still computed over the raw values, so only the wire encoding changes and the server recovers the same values after unescaping.Validation: added two unit tests in
bind_test.gothat fail on the current code (the raw quote breaks out) and pass with the escape applied.