Use CURSOR_CONVERSATION_ID as session id on Cursor (with temp debug logs)#12
Draft
swarup-padhi-glean wants to merge 1 commit into
Draft
Use CURSOR_CONVERSATION_ID as session id on Cursor (with temp debug logs)#12swarup-padhi-glean wants to merge 1 commit into
swarup-padhi-glean wants to merge 1 commit into
Conversation
plugins/glean/start.sh now maps Cursor's CURSOR_CONVERSATION_ID to the normalized GLEAN_SESSION_ID, mirroring how CLAUDE_CODE_SESSION_ID is handled (host-awareness stays in the launcher; the bundle keeps reading only GLEAN_SESSION_ID). Bumps plugin manifests 0.2.24 -> 0.2.25. Includes TEMPORARY debug logs (start.sh + src/session-id.ts) marked 'DEBUG (remove before merge)' so the resolved session id can be traced while testing in Cursor. These must be removed before merge.
Contributor
Author
|
@mohit-gupta-glean @eshwar-sundar-glean unfortunately cursor doesn't inject the CURSOR_CONVERSATION_ID var into the mcp server process env, so this isn't avl and we will have to fallback to random uuid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Maps Cursor's
CURSOR_CONVERSATION_IDto the normalizedGLEAN_SESSION_IDinplugins/glean/start.sh, mirroring howCLAUDE_CODE_SESSION_IDis handled. Host-awareness stays in the launcher; the bundle keeps reading onlyGLEAN_SESSION_ID(src/session-id.tsunchanged in behavior). Cursor previously fell back to a per-process UUID; now it uses the real conversation id.Marked
DEBUG (remove before merge):plugins/glean/start.sh: stderr line showing which host var fed the session id.src/session-id.ts: stderr line showing the resolved id (host vs fallback).These are only to verify the wiring in Cursor; strip them (and rebuild
dist) before merge.Version
Manifests bumped 0.2.24 → 0.2.25.
Note
The old
CODEX_THREAD_IDmapping was dropped whenpackages/codexwas removed; this PR scopes to Cursor only.