Mark dist bundles as generated to suppress diffs#11
Merged
Conversation
mohit-gupta-glean
requested review from
eshwar-sundar-glean and
garvit-scio
as code owners
mohit-gupta-glean
force-pushed
the
gitattributes-generated-diffs
branch
2 times, most recently
from
e4d5c70 to
909e4be
Compare
- Add packages/codex/dist/** to .gitattributes with linguist-generated and -diff so GitHub collapses them and git diff suppresses content. - Update rebuild hook to use an ignorelist — skip rebuild only when ALL staged files are non-source (docs, CI, git metadata, hooks). New source paths automatically trigger rebuilds without needing to update the hook.
mohit-gupta-glean
force-pushed
the
gitattributes-generated-diffs
branch
from
909e4be to
f0a7eb3
Compare
| @@ -1,8 +1,14 @@ | |||
| #!/bin/bash | |||
| # Rebuild dist/index.js and stage it on every commit. | |||
| # Rebuild dist/index.js and stage it on every commit that touches source files. | |||
Collaborator
There was a problem hiding this comment.
Probably not needed, Codex seems to be fixed now
Contributor
Author
There was a problem hiding this comment.
Merging this anyway. You can drop it as part of your PR. Don't think having the attribute will break anything.
Contributor
Author
There was a problem hiding this comment.
There are also other useful changes in the PR.
Collaborator
There was a problem hiding this comment.
Yea, codex as well does not honour in its new update
eshwar-sundar-glean
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/codex/dist/**to.gitattributeswithlinguist-generatedand-diffso GitHub collapses them in PR review andgit diffsuppresses their contentTest plan
git diff --exit-codestill detects out-of-sync dist (exits non-zero with "Binary files differ")check-version-bumpunaffected —.gitattributesand.githooks/don't matchPLUGIN_PATHS.gitattributes) skip rebuild and version bump