extract filter from replace#111
Open
kristianmandrup wants to merge 2 commits into
Open
Conversation
Author
|
Also, please do some documentation of the internal architecture :) |
Owner
|
Yeah, might not merge this exact diff, but I should factor this out you're right |
Author
|
Perhaps you could instead help me on my branch. I did a lot of work on refactoring alrwady |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please help extract filter from replace (PR not to working, but clearly shows intent)
Currently the code is extremely "poor" and very hard to "grasp" as too much is "bundled together".
Please divide and conquer so we can have Single Responsibility.
Thanks ;)
PS: I used to do a lot of LiveScript, but been a while...