Repository navigation
Conversation
|
@MaxRink Thank you for your contributions. In all your other PRs please include your human issue (eg. #287). The preferred approach is issue first, not PR first. |
|
As for this specific PR, I am unlikely to merge it. The warnings added are further evidence that this is ill fitting. I would prefer we reduce the UI elements, not increase them. |
Geotagging sessions gave no way to check the GPS fix while a camera was connected. The GPS data page was only reachable from the settings menu, which means disconnecting first. Add a 'GPS Data' item to the connected page. It loads the existing GPS data page with the same shared page pattern the intervalometer already uses, and starts the same refresh timer. The item is hidden when GPS is disabled, matching the settings menu entry. Clear the back button disabled state when the GPS data page loads. The connected page disables and hides the back button and nothing restored it. Back returns to the connected page, never to the main menu, while a camera is connected. The connected page grid on Core and Core2 is now two by two to fit the fourth item. Disconnect moves from the top right to the bottom right. Assisted-by: claude-code:claude-opus-5 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
e520611 to
7e23ad9
Compare
|
Thank you for the direction, that reframed it well. The real problem was never editing settings mid-session, it was that the GPS data page is unreachable while connected during a geotagging session. The PR is reworked to exactly that: one GPS Data item on the connected page opening the existing read-only page, warnings and the settings entry are gone, and nothing else changed. Net UI delta is one menu item that only appears when GPS is enabled. On process: all our open PRs now lead with the motivation, and new changes will come as an issue first. |
@MaxRink I provided a properly considered reply in this PR and did not receive what I consider an acceptable human response, please correct me if I'm wrong. As a result, I will be rejecting all PRs and issues from this account. If you wish, you may email me personally to discuss the situation. |
|
No worries, then I'll just maintain an optimized fork. |
Thank you for your understanding. Many people rely on the simplicity and robustness of this project. |
2 participants
During a geotagging session there is no way to check the GPS fix, satellite count, or how old the last position is, because the GPS data page sits under Settings and Settings is only reachable from the main menu. Getting to it means dropping the camera connection, which defeats the purpose. Editing settings while connected was never the point, the point is seeing the data.
The connected page now has a GPS Data item that opens the existing page, with the same refresh timer and the same shared page wiring the intervalometer uses. It is hidden when GPS is disabled, matching the settings entry. Back from that page returns to the connected page and never to the main menu. No new settings, no new dialogs, one new menu item. On Core and Core2 the connected page is now a two by two grid to fit it, so Disconnect moves from top right to bottom right.
Built for m5stick-s3, m5stick-c-plus and m5stack-core2. Not tested on hardware yet, so the on-device walk (connect, open GPS Data, confirm live updates, back to connected, fire the shutter) is still outstanding. Camera code paths are untouched.
Plan document: https://github.com/MaxRink/furble/blob/plans/plans/03-settings-while-connected.md
🤖 Generated with Claude Code