Skip to content

chore(deps): bump preact to 11.0.1 and @astrojs/preact to 6.1.0 - #169

Merged
jldeen merged 1 commit into
mainfrom
jldeen-pr-merge-readiness-check
Oct 19, 2026
Merged

jldeen merged 1 commit into
mainfrom
jldeen-pr-merge-readiness-check

Conversation

@jldeen

@jldeen jldeen commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Supersedes #167.

Problem

Dependabot's preact 10 → 11 bump (#167) fails npm ci with ERESOLVE: @astrojs/preact@6.0.x only allows preact@^10.6.5.

Fix

  • Bump @astrojs/preact to ^6.1.0 alongside preact ^11.0.1. 6.1.0 widens the peer range to ^10.6.5 || ^11.0.0 (Update dependency preact to v11 withastro/astro#18389). All other preact-ecosystem deps (@preact/signals, @prefresh/*, preact-render-to-string) already accept preact 11, and npm ls preact resolves to a single deduped 11.0.1.
  • Preact 11 types <input> attributes per type, so TextInput's union-typed type prop ("text" | "email" | "password" | "url") no longer type-checks. It's now split into one object per input type before being spread onto <input>. No casts; invalid type/role combos still error. Runtime output is unchanged (type="text").

Validation (Node 22, same steps as CI)

  • npm ci ✅
  • npm run check: 0 errors ✅
  • npm run build ✅
  • npm run test: 12/12 Playwright ✅
  • Full-page screenshots on desktop (1440×900) and mobile (390×844) are pixel-identical to main, with no console or page errors. The TextInput island hydrates and accepts input.

Notes

Supersedes #167. @astrojs/preact 6.0.x only allows preact ^10, so the
Dependabot bump fails `npm ci` with ERESOLVE. 6.1.0 widens the peer
range to `^10.6.5 || ^11.0.0` (withastro/astro#18389).

Preact 11 types <input> attributes per `type`, so TextInput's
union-typed `type` prop no longer type-checks. Split it into one object
per input type before spreading it onto <input>.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings October 19, 2026 21:14
@jldeen
jldeen requested a review from Damovisa as a code owner October 19, 2026 21:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The Preact major upgrade affects site-wide React compatibility and warrants final human validation.

No open issues 🎉

What changed in this PR

Upgrades the site’s Preact integration to resolve the peer-dependency conflict blocking #167.

Changes:

  • Update Preact to 11.0.1 and @astrojs/preact to 6.1.0.
  • Adapt TextInput typing for Preact 11 without changing runtime behavior.
File Description
src/​components/​ui/​FormControls.tsx Adjust input attribute typing for Preact 11.
package.json Update Preact and Astro integration requirements.
package-lock.json Refresh resolved dependencies and package metadata.

Review effort: Max

@jldeen
jldeen merged commit 9f2464d into main Oct 19, 2026
10 checks passed
@jldeen
jldeen deleted the jldeen-pr-merge-readiness-check branch October 19, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants