Repository navigation
chore(deps): bump preact to 11.0.1 and @astrojs/preact to 6.1.0 - #169
Merged
Merged
Conversation
Supersedes #167. @astrojs/preact 6.0.x only allows preact ^10, so the Dependabot bump fails `npm ci` with ERESOLVE. 6.1.0 widens the peer range to `^10.6.5 || ^11.0.0` (withastro/astro#18389). Preact 11 types <input> attributes per `type`, so TextInput's union-typed `type` prop no longer type-checks. Split it into one object per input type before spreading it onto <input>. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The Preact major upgrade affects site-wide React compatibility and warrants final human validation.
No open issues 🎉
What changed in this PR
Upgrades the site’s Preact integration to resolve the peer-dependency conflict blocking #167.
Changes:
- Update Preact to 11.0.1 and
@astrojs/preactto 6.1.0. - Adapt
TextInputtyping for Preact 11 without changing runtime behavior.
| File | Description |
|---|---|
src/components/ui/FormControls.tsx |
Adjust input attribute typing for Preact 11. |
package.json |
Update Preact and Astro integration requirements. |
package-lock.json |
Refresh resolved dependencies and package metadata. |
Review effort: Max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #167.
Problem
Dependabot's preact 10 → 11 bump (#167) fails
npm ciwithERESOLVE:@astrojs/preact@6.0.xonly allowspreact@^10.6.5.Fix
@astrojs/preactto^6.1.0alongsidepreact^11.0.1. 6.1.0 widens the peer range to^10.6.5 || ^11.0.0(Update dependency preact to v11 withastro/astro#18389). All other preact-ecosystem deps (@preact/signals,@prefresh/*,preact-render-to-string) already accept preact 11, andnpm ls preactresolves to a single deduped11.0.1.<input>attributes pertype, soTextInput's union-typedtypeprop ("text" | "email" | "password" | "url") no longer type-checks. It's now split into one object per input type before being spread onto<input>. No casts; invalid type/role combos still error. Runtime output is unchanged (type="text").Validation (Node 22, same steps as CI)
npm ci✅npm run check: 0 errors ✅npm run build✅npm run test: 12/12 Playwright ✅main, with no console or page errors. TheTextInputisland hydrates and accepts input.Notes
package-lock.json, so it will need a lockfile regen if chore(deps): bump the minor-and-patch group with 6 updates #166 merges first.npm audit's 2 findings (fast-uri,http-cache-semantics) are pre-existing onmainand unrelated to this change.