Simplify npm publish step in workflow#32
Open
gracepark wants to merge 1 commit into
Open
Conversation
Removed npm whoami command from publish step.
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify the GitHub Actions release workflow used to publish the package to npm.
Changes:
- Removes
npm whoamifrom the publish step. - Modifies the npm publish step invocation (and currently also removes the auth env block for the step).
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Simplifies the npm publish step in the release workflow (but also drops the publish auth env configuration). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
maraisr
approved these changes
May 11, 2026
Author
|
Hi @maraisr! Thanks for the review! I noticed that I'm running into this error:
I'm unable to see the settings on the repo since (I don't have permissions). Would you be able to check this for me? I think you can disable the CodeQL-block repo custom property to immediately disable CodeQL blocking this PR, but I'm not sure if that's what your team would want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
Removed npm whoami command from publish step.