Repository navigation
docs(fork): name the merged commits of the snapshot-tar rows - #261
Merged
Merged
Conversation
The two rows carried from upstream's PATH_MAX-safe snapshot tars named only their pull request. They now name the rebase-merged commits on the line and the first release that carries them, as every other row does. Signed-off-by: Timo Derstappen <teemow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The two FORK.md rows carried from upstream's PATH_MAX-safe snapshot tars (agent-substrate#2110 and agent-substrate#2111, #260) name only their pull request in the "Fork commit" column. Every other row names the commit as it is on the line and the first release carrying it.
Proposed solution
Name the rebase-merged commits
3afd756f(agent-substrate#2110) andeb04dfc1(agent-substrate#2111), the merge date and the first release,1.8.0-rc.6, in the same shape as the other rows.Acceptance criteria
giantswarm, the pull request, the merge date and the first release.docs(fork)edit of FORK.md alone needs no row of its own).Opened by an agent on behalf of Timo Derstappen.