Repository navigation
fix(ci): move the agentgateway-image parameter to 2.2.2 with the chart - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #111, for #109.
Problem
#111 moved the chart default
images.agentgatewayto 2.2.2 but did not move theagentgateway-imageparameter in.circleci/config.yml. The publish job checks that the two are equal, so the tag pipeline of v1.3.1-rc.5 failed atpublish/chartswith "images.agentgateway differs from the agentgateway-image parameter". The images were published; the charts were not.Change
.circleci/config.yml:agentgateway-imagegoes togsoci.azurecr.io/giantswarm/agentgateway-upstream/agentgateway:2.2.2, the same value as the chart default.FORK.md: the "agentgateway it runs" row names 2.2.2 (tagv2.2.2on149d9b40). That is 2.2.1 plus agentgateway-upstream#35, which makes an unreachable policy service a 503, minus the named MCP buffer error that agentgateway-upstream#36 reverted.The open #104, #106, #107 and #108 also edit FORK.md, but only the section near line 73. This PR changes only the row on line 31, so they do not overlap.
Verification
This PR's tag pipeline publishes both charts, and the resulting RC is checked end to end in a test cluster.
This PR was written by an agent.