Repository navigation
feat: a skills GitHub App source for agent-manager's skill resolution - #507
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A lab's agent-manager resolves skills either anonymously (60 requests an hour per egress address, shared by the machine) or with a static token. A lab should reach GitHub as a GitHub App. agent-manager's chart already takes a read-only skills App (
skills.github.app.secretName), but agentlab cannot wire it. Fixes #505.Proposed solution
githubAppinagentlab.yaml(configure --github-app-id,--github-app-installation-id,--github-app-private-key-source): public ids plus a reference to the private key, validated (complete, numeric ids, the key a reference, not together withgithubToken.source, which the chart refuses too).up/platformwrites the Secretagentlab-github-appinagent-platformbefore the install. agentlab server-side-appliesapp-idandinstallation-id, andbeekeeper secret copy --to-secretpatchesprivate-key, which agentlab never reads; a failed placement fails the run.agent-manager.skills.github.app.secretNameinstead oftokenSecret. The portal and the migrate Job keep a$GITHUB_TOKENif one is given, since they take a token only.discovernames the App and its preflight checks the secret tooling. The refreshSkills SKIP hints name the App. Documented indocs/agents.mdanddocs/cli.md.Acceptance criteria
tokenSecret; nothing changes without an App or on the 3.x line; the ids are applied, the key is handed to the tooling and never written by agentlab, and a failed placement fails.(Written by an agent.)