fix(integrations/google-adk): add py.typed sentinel for PEP 561 compliance#552
Open
FBISiri wants to merge 1 commit into
Open
fix(integrations/google-adk): add py.typed sentinel for PEP 561 compliance#552FBISiri wants to merge 1 commit into
FBISiri wants to merge 1 commit into
Conversation
…iance Add an empty py.typed marker file to src/zep_adk/ so that downstream mypy/pyright consumers of the zep-adk package can resolve types inline without stubs, per PEP 561. Hatchling automatically includes all files under the declared package directory (src/zep_adk), so no additional build-config changes are required beyond the sentinel file itself. A clarifying comment is added to pyproject.toml. No logic changes. CI should pass as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an empty
py.typedmarker file tointegrations/adk/python/src/zep_adk/, enabling downstreammypy/pyrightconsumers to resolve types from the installed package inline — no stubs required.What changed
integrations/adk/python/src/zep_adk/py.typedintegrations/adk/python/pyproject.toml[tool.hatch.build.targets.wheel]Why
PEP 561 requires a
py.typedmarker for a package to be considered a typed package. Without it, mypy and pyright skip inline type checking and fall back to stubs orAny. Thezep-adkpackage already has full type annotations and a strict mypy config (disallow_untyped_defs = true) — the marker just makes that signal legible to downstream consumers.Impact
src/zep_adk), so no build configuration changes are required.pip install zep-adkwill immediately benefit from inline type resolution.Related