feat(litellm): Support span streaming#6317
Draft
alexander-alderman-webb wants to merge 1 commit into
Draft
Conversation
Contributor
Codecov Results 📊✅ 85 passed | ❌ 74 failed | Total: 159 | Pass Rate: 53.46% | Execution Time: 2m 11s ❌ Failed Tests
|
| File | Patch % | Lines |
|---|---|---|
tracing_utils.py |
33.29% | |
litellm.py |
88.89% |
Generated by Codecov Action
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 49ec553. Configure here.
| events = [item.payload for item in items if item.type == "transaction"] | ||
| assert len(events) == 3 | ||
|
|
||
| sentry_sdk.flush() |
There was a problem hiding this comment.
Sync test captures only transactions, missing span validation
Medium Severity
In the sync test_multiple_providers, capture_items("transaction") only captures transaction-type items. The newly added sentry_sdk.flush() before spans = [item.payload for item in items if item.type == "span"] suggests an intent to capture and validate spans, but the filter at capture time excludes them. This makes the span assertions in the for loop vacuously true — they never execute. The async counterpart test_async_multiple_providers correctly uses capture_items("transaction", "span"), confirming this is an oversight.
Reviewed by Cursor Bugbot for commit 49ec553. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
sentry_sdk.traces.start_spanand replaceSpan.set_data()withStreamedSpan.set_attribute()when in span streaming mode.Parametrize tests on the trace lifecycle option.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)