Repository navigation
Fix title editors shrinking and clipping while editing - #7889
Open
TravisCossarini wants to merge 2 commits into
Open
TravisCossarini wants to merge 2 commits into
TravisCossarini wants to merge 2 commits into
Conversation
Clicking a query or dashboard title swaps it for an antd Input inside an inline-block wrapper, so the input fell back to its default ~20-character width and 14px font (the smaller font was noted as a side effect in getredash#4493). Long titles collapsed and scrolled, and growing a short title clipped. While a title is being edited, let its .page-title take the rest of the title row and give the input the full width and the title's font. Browsers without :has() keep the current behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates the shared title styles so query and dashboard title editors use more space and inherit the title font.
Reviews (2) · Last reviewed commit: "Merge branch 'master' into fix/query-tit..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Clicking a query or dashboard title to rename it swaps the title for an input that is much smaller than the title:
<Input>sits inside.edit-in-place, aninline-blockwrapper that sizes itself to its content, so the input falls back to its default ~20-character width and long titles get cut off.This PR adds 18 lines of CSS to the shared
.page-titlestyles inbase.less. While a title is being edited, its.page-titletakes the rest of the title row, and the input gets the full width and the title's font. There are no JavaScript changes..page-title.:has(.edit-in-place.active). Browsers without:has()keep the current behavior.How is this tested?
Tested in Chrome against the Docker dev stack (
make up), and at phone width with Playwright's iPhone 13 emulation:I ran every CI job locally against this commit: backend and frontend lint, prettier, Jest and viz-lib tests, the production build, Cypress, the Playwright visual tests and pytest. They all pass. There are no JS changes, and the visual tests capture titles while they aren't being edited.
Related Tickets & Documents
Related to #4097 (Improve visibility of editable titles). This doesn't address discoverability, but it follows that issue's second conclusion about the input taking the title's space in edit mode. The smaller editing font comes from #4493. I couldn't find an existing issue about the input collapsing or clipping.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Desktop: before, the field collapses and scrolls while typing:
Desktop: after, the field fills the title row in the title's font:
Mobile (iPhone 13 emulation, 390px)
🤖 Generated with Claude Code