Improve follow-up environment story coverage - #2530
Open
brsbl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The follow-up composer story catalog defaulted every
Rowwithout an explicit environment fixture to the same local-direct summary, so most functional states repeated one environment treatment. The focused environment matrix covered only direct local/remote and managed local/remote worktrees; it omitted unmanaged, named, and detached worktree shapes, and the detached fixture omitted its machine label so its worktree icon could not render.What changed
Environment matrixwith unmanaged, named, and detached worktree rows.FolderGitenvironment icon is visible.Loadingspinner because discovery has not yet confirmed the eventual workspace type.Before — parent PR head
7b7f9c645bf88916298e664c444110df18cd2ff3The matrix stopped after managed local/remote worktrees, and generic overview rows overwhelmingly inherited the local-direct fixture.
After — child head
3c86463a7650be23c225f191194cf39de1f967a8The matrix exposes every meaningful label/icon shape, while the overview exercises a balanced direct/worktree mix.
How you verified
/meta.json:thread--timeline--rows--tool--native-skill-callandpromptbox--follow-up-prompt-box--environment-matrixboth exist.Loaded skill · visual-qa-loopwith theZapicon.Loading; direct local/remote useLaptop; managed, unmanaged, named, and detached worktrees useFolderGit; destroyed uses the archived banner. Every environment-type accessible label matched its fixture.Laptop, 11FolderGit, and 1Loadingenvironment treatments, with no horizontal overflow at 1440×1100.pnpm exec turbo run typecheck --filter=@bb/apppassed on the final head.pnpm exec turbo run lint --filter=@bb/appcompleted with 0 errors; the repository's existing warnings remain.oxfmt --checkandgit diff --checkpassed.BB-Thread-ID: thr_sjdd7gudiq