Move thread search into the command palette - #2474
Open
brsbl wants to merge 7 commits into
Open
Conversation
…43' into bb/build-search-palette-layer-thr_z45dnp4jyw # Conflicts: # apps/app/src/components/sidebar/AppSidebar.tsx # apps/app/src/components/sidebar/ProjectList.tsx # apps/app/src/components/sidebar/SidebarThreadSearchPanel.test.tsx
brsbl
changed the base branch from
bb/sidebar-lifecycle-drafts-search-thr_2e2gbjx943
to
bb/sidebar-splits-thr_2e2gbjx943
August 26, 2026 11:35
…43' into bb/build-search-palette-layer-thr_z45dnp4jyw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Thread search was owned by the sidebar while the quick palette mixed no domain-search model into its command surface. That left
thread.searchtied to sidebar visibility and provided no reusable boundary between root commands and searchable content modes.What changed
thread.searchcommand and bindingPluginThreadListsearch contractHow you verified
pnpm exec turbo run test --filter=@bb/app -- --run ...— 14 focused test files, 78 tests passed, covering the palette/root/mode contract, local drafts, match clipping, split state, AppLayout integration, and sidebar regressionspnpm exec turbo run typecheck --filter=@bb/app— passedpnpm exec turbo run lint --filter=@bb/app— passed with 0 errors; oxlint reported the repository's existing warnings, with none in the new palette filesnode packages/plugin-sdk/scripts/check-npm-version-guard.mjs— passed against Phase 4's current SDK versiongit diff --check— passedVisual QA pending
Visual QA was not run because this implementation host is headless. Chrome for Testing, real Safari, and before/after screenshots still need to verify:
thread.searchFixes: N/A — stacked implementation layer; no issue was supplied.
BB-Thread-ID: thr_z45dnp4jyw