Repository navigation
[TASK] Stub core file reference in media preview test - #2860
Merged
Merged
Conversation
georgringer
force-pushed
the
task/fix-fal-media-preview-test
branch
from
October 12, 2026 08:05
8080c0c to
686f910
Compare
TYPO3 14 reads the context of the original file's metadata on every FileReference::getProperties() call. The test only set mergedProperties on partial mocks without an original file, so the property access failed with "originalFile must not be accessed before initialization". Stub getProperty() of the core file reference instead, so the test no longer depends on its internals.
Fractor 1.1 normalizes the XLIFF files differently, so the Fractor job of the highest dependencies run reports all language files as changed. Pin the core package and the XML and XLIFF packages to the 1.0 line until the files are adapted.
georgringer
force-pushed
the
task/fix-fal-media-preview-test
branch
from
October 12, 2026 08:16
686f910 to
7177e0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewsTest::falMediaPreviewsAreReturnedfails on TYPO3 14:FileReference::getProperties()now reads the original file's metadata context on every call, but the test only setmergedPropertieson mocks without an original file.getProperty()of the core file reference instead, so the test no longer depends on core internals.Test plan
🤖 Generated with Claude Code