Skip to content

[TASK] Stub core file reference in media preview test - #2860

Merged
georgringer merged 2 commits into
mainfrom
task/fix-fal-media-preview-test
Oct 12, 2026
Merged

georgringer merged 2 commits into
mainfrom
task/fix-fal-media-preview-test

Conversation

@georgringer

@georgringer georgringer commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • NewsTest::falMediaPreviewsAreReturned fails on TYPO3 14: FileReference::getProperties() now reads the original file's metadata context on every call, but the test only set mergedProperties on mocks without an original file.
  • Stub getProperty() of the core file reference instead, so the test no longer depends on core internals.

Test plan

  • Unit suite green locally (285 tests, core 13.4.34)
  • CI green on the 14.3 matrix

🤖 Generated with Claude Code

@georgringer
georgringer force-pushed the task/fix-fal-media-preview-test branch from 8080c0c to 686f910 Compare October 12, 2026 08:05
TYPO3 14 reads the context of the original file's metadata on every
FileReference::getProperties() call. The test only set mergedProperties
on partial mocks without an original file, so the property access
failed with "originalFile must not be accessed before initialization".

Stub getProperty() of the core file reference instead, so the test no
longer depends on its internals.
Fractor 1.1 normalizes the XLIFF files differently, so the Fractor
job of the highest dependencies run reports all language files as
changed. Pin the core package and the XML and XLIFF packages to the
1.0 line until the files are adapted.
@georgringer
georgringer force-pushed the task/fix-fal-media-preview-test branch from 686f910 to 7177e0d Compare October 12, 2026 08:16
@georgringer
georgringer merged commit 36a5a98 into main Oct 12, 2026
34 checks passed
@georgringer
georgringer deleted the task/fix-fal-media-preview-test branch October 12, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant