feat(voyage): add voyage-code-4 embedding model - #19
Conversation
|
VERDICT:APPROVED Reviewed the diff, conventions, breaking-change risk, tests, docs, and commit hygiene. Correctness — New Fit with conventions — Adding a model = a cost-map entry plus a test; matches how models are registered here. No code paths touched, so no separate docs needed (the cost map is self-documenting). Breaking-change risk — None. Pure additive JSON entry. If the model isn't live yet, calls fail at Voyage's API, not in litellm; nothing existing changes. Tests — Commit hygiene — Clean. No Note (non-blocking) — Pricing/specs are guessed from |
|
VERDICT:APPROVED Clean, low-risk addition. Reviewed correctness, convention fit, breaking-change risk, tests, docs, and commit hygiene. Correctness
Convention fit
Breaking-change risk: none. Pure additive entry + new tests. Tests: Docs: PR body clearly states the model is not officially released and values mirror voyage-code-3 pending final specs. Honest and self-documenting. Commit hygiene: single commit, conventional-commit message, authored by fzowl. No Non-blocking note: values are speculative (unreleased model). Fine to merge given the explicit caveat in the description, but re-verify |
|
VERDICT:APPROVED SummaryRegisters Correctness
Convention fit
Tests
Breaking-change risk
Commit hygiene
Minor note (non-blocking)
Approving. |
|
Housekeeping: brought the branch up to date by merging |
|
VERDICT:APPROVED ReviewCorrectness — Clean. Conventions — Matches project patterns. Unit tests land in Breaking-change risk — None. Purely additive; no existing entries touched. Tests — Two focused tests: one asserts the raw backup-map entry fields, one asserts Docs — N/A. Model-map entries are self-documenting; no separate doc needed. Commit hygiene — Clean. No Co-Authored-By, no 'Generated with', no Minor note (non-blocking) — Pricing/specs are speculative (model not officially released), so cost tracking could be wrong until real specs publish. PR body is transparent about this and flags it for update. Acceptable given the disclosure; just remember to reconcile once official numbers land. |
|
VERDICT:APPROVED Reviewed the What it does: Registers Correctness ✅
Convention fit ✅ — Purely additive, follows the established provider-model-registration pattern (embedding models resolve dynamically from the cost map, so no further routing wiring is needed). Breaking-change risk ✅ None — pure addition; no existing entries or behavior touched. Tests ✅ — Commit hygiene ✅ — No Minor (non-blocking) suggestions:
Neither issue blocks merge. Clean, low-risk, well-tested addition — approved. |
2b1d8b5 to
e93725c
Compare
|
VERDICT:APPROVED Reviewed the diff, the tests, and the upstream counterpart (BerriAI#36820). Correctness — The new Conventions & breaking-change risk — Purely additive to the cost map; no code paths change and nothing existing is modified, so there is no breaking-change risk. Tests live under Tests — Good. Commit hygiene — Clean. Both commits are authored by fzowl zoltan@voyageai.com, no Upstream BerriAI#36820 has no outstanding maintainer requests (the only review was the automated greptile nit, already addressed). Nothing blocking here. |
What
Adds the
voyage/voyage-code-4embedding model to the model cost map in bothmodel_prices_and_context_window.jsonandlitellm/model_prices_and_context_window_backup.json.The model is not officially released yet, so its entry mirrors the existing
voyage-code-3details:litellm_providervoyagemodeembeddingmax_input_tokens/max_tokens32000input_cost_per_token1.8e-07($0.18 / 1M tokens)output_cost_per_token0.0These values should be updated once the model's final specs and pricing are published.
Why
Lets users reference
voyage/voyage-code-4for embeddings and get correct cost tracking / model info once it becomes available, without waiting for a separate release.Tests
Adds
tests/test_litellm/llms/voyage/test_voyage_code_4.py:litellm.get_model_info("voyage/voyage-code-4")resolves itBoth pass locally (
2 passed).