ci(#7045): add security-hook pytest suite to script-test target - #7046
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
ci(#7045): add security-hook pytest suite to script-test target#7046fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The ~500 pytest tests under internal/security/hooks/ were not run by any CI job. A regression in a PreToolUse or PostToolUse hook could land without any required check failing. Add the pytest invocation to the script-test Makefile target, which is already called by the lint.yml workflow on every PR and push to main. This folds the hooks suite into the existing test job with no workflow changes needed, since pytest is already installed in that job's setup step. Closes #7045
|
🤖 Finished Review · ✅ Success · Started 2:54 PM UTC · Completed 3:06 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.14 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsA minimal 1-file, 3-line Makefile change that precisely addresses a documented CI gap; the score reaches moderate (rather than low) because the Makefile is a high-churn, multi-author hub with 16 commits in 30 days and a dense fix/revert history, and the CI_WORKFLOW_CHANGED signal is elevated, but these structural risks are offset by a near-perfect scope-to-issue match and an additive, easily revertible change. |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the security-hook Python test suite (~500 tests under
internal/security/hooks/) to thescript-testMakefile target so it runs in CI on every PR and push to main. Previously, no CI job ran these tests — a regression in any PreToolUse or PostToolUse hook could land without any check failing.Related Issue
Closes #7045
Changes
python3 -m pytest internal/security/hooks/ -vto thescript-testMakefile target, folding it into the existingtestjob inlint.ymlscript-testhelp description to mentionsecurity-hooksNo workflow file changes needed —
lint.ymlalready runsmake script-testand installspytest.Testing
python3 -m pytest internal/security/hooks/ -v— all 497 tests passmake helpshows updated descriptionCloses #7045
Post-script verification
agent/7045-ci-security-hook-tests)6d496c4ce54bcccefdcbd5bec1ab44f775a33de8..HEAD)