Skip to content

Add GitHub --app-set support to repos install #7882

Description

@ggallen

What is missing

fullsend repos install does not support selecting the GitHub App set used by a repository. This prevents manifest-managed repositories from using the same custom app-set configuration supported by fullsend github setup.

The option is GitHub-specific. It should not affect GitLab installation behavior or GitLab manifest validation.

What should happen

Add GitHub app-set support to fullsend repos install:

  • Add an --app-set command-line option.
  • Add a manifest-level default in repos.yaml.
  • Allow an individual repository entry to override that default.
  • Resolve the effective value using the same precedence and override semantics as comparable repos install options.
  • Persist the effective app-set value on the target GitHub repository in the same way as fullsend github setup, including the FULLSEND_APP_SET repository variable required by dispatch and fix workflows.
  • Ensure reruns and convergence preserve and repair the effective value rather than silently replacing a custom value with the built-in default.
  • Reject or ignore the option appropriately for GitLab instead of applying GitHub behavior to GitLab projects.

The app-set behavior should match fullsend github setup for the relevant GitHub application settings. Shared validation, resolution, and application-setting logic should be factored into common code wherever practical instead of being reimplemented separately in the two commands.

Precedence

Use the established repos install precedence model for scalar options, including the built-in default, manifest defaults, per-repository overrides, and command-line values where applicable. Document the exact precedence and any unset/disable sentinel behavior so it is consistent with other manifest-managed options.

Documentation and testing

Update the CLI reference, repository-management guides, and manifest/configuration documentation. Add tests covering:

  • command-line, manifest-default, and per-repository values
  • precedence and unset/override behavior
  • the built-in default
  • fresh install, rerun, and convergence
  • repository-variable output and drift repair
  • GitHub-only validation and GitLab behavior
  • parity of app-set validation and application settings with fullsend github setup

The implementation must not weaken exact bot-identity matching or introduce wildcard bot recognition.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    component/installCLI install and app setupfeatureFeature-category issue awaiting human prioritizationtriagedTriaged but awaiting human prioritizationtype/featureNew capability request

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions