fix(#2093): retry empty PR file list before refusing to approve - #1196
Open
shairevivo wants to merge 2 commits into
Open
fix(#2093): retry empty PR file list before refusing to approve#1196shairevivo wants to merge 2 commits into
shairevivo wants to merge 2 commits into
Conversation
post-review.sh refuses to approve a PR when it cannot establish what
changed, guarding against blind approvals. But the file list can come
back empty transiently: right after a merge-commit update GitHub has
not finished computing the diff, so the review agent fails a genuinely
non-empty PR.
Two changes:
- forge_get_pr_files (GitHub) now reads the paginated
/pulls/{n}/files REST endpoint instead of the async-populated
`gh pr view --json files` summary field, which reflects the computed
diff more directly.
- The call site retries once (notice + short sleep + re-fetch) before
the empty-result guard. The retry recovers from a transient race; a
genuinely empty result still refuses to approve. This applies to all
forges since the guard is forge-agnostic.
Adds integration tests for retry-recovers and retry-still-fails, and
regenerates the post-review.sh / pre-review.sh bundles.
Fixes fullsend-ai/fullsend#2093
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Shai Revivo <srevivo@redhat.com>
Functional tests did not runFunctional tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the |
PR Summary by QodoRetry transient empty PR file lists before blocking approval
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo
1. Protected scripts need human review
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
The empty-PR-files retry branch calls `sleep 10` before re-fetching. The integration tests prepend only MOCK_BIN to PATH and provided no `sleep` mock, so the real sleep ran in all three empty-list cases (retry-recovers, retry-still-fails, and the pre-existing safety-net-independent test), adding ~30s to every serial suite run. Add a no-op `sleep` mock to MOCK_BIN. The retry logic doesn't depend on real elapsed time, so stubbing it keeps the tests deterministic and fast without changing what they assert. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Shai Revivo <srevivo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the review agent failing genuinely non-empty PRs when the forge returns an empty changed-files list.
post-review.shrefuses to approve a PR when it cannot establish what changed (a safety net against blind approvals). But the file list can come back empty transiently: right after a merge-commit update, GitHub has not finished computing the diff, soforge_get_pr_filesreturns nothing and the agent aborts on a PR that actually has changes.Changes
scripts/lib/github-review-ops.lib.sh—forge_get_pr_filesnow reads the paginated/pulls/{n}/filesREST endpoint instead of the asynchronously-populatedgh pr view --json filessummary field. The files endpoint reflects the computed diff more directly.scripts/post-review.src.sh— the empty-result guard now retries once (::notice::+ shortsleep+ re-fetch) before refusing to approve. The retry recovers from the transient race; a genuinely empty result still refuses to approve. This lives at the call site, so it protects every forge (GitHub + GitLab) regardless of whichforge_get_pr_filesimplementation runs.scripts/post-review-test.sh— mockghupdated for the new endpoint; addedempty-pr-files-retry-recoversandempty-pr-files-retry-still-failsintegration tests.post-review.shandpre-review.shbundles (make script-build).Verification
make script-build+make check-bundle— bundles in syncbash scripts/post-review-test.sh— 106 pass, incl. both new testsmake lint(skillsaw) — Grade A, 0 errors/warningspre-commit runon changed files — shellcheck + secret scan passThe remaining
harness-jira-test.shfailures undermake script-testare pre-existing and env-dependent (unsetJIRA_*vars); they reproduce on a cleanmainand are unrelated to this change.Note: the tracking issue lives in
fullsend-ai/fullsend#2093, but the bug and fix are in this repo (the review scripts).🤖 Generated with Claude Code