Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9a7d116
feat(review): filter unreviewable content from diff context
guyoron1 Aug 25, 2026
537480c
fix(review): review round 1 — header-path fallback, bounded buffering…
guyoron1 Sep 2, 2026
cdf3674
fix(review): review round 2 — header split, quoted renames, one-line …
guyoron1 Sep 2, 2026
9dc7de8
fix(review): review round 3 — src-not-bundle, marker gating, GitLab s…
guyoron1 Sep 2, 2026
2775b14
fix(review): review round 4 — info-only disclosure exemption, paired …
guyoron1 Sep 2, 2026
951b7a3
docs(review): excluded-content disclosure names all exclusion categories
guyoron1 Sep 3, 2026
e388990
fix(review): settle generated markers from the file head, not the hunk
guyoron1 Sep 5, 2026
a05fce5
test(review): cover mid-file regen, forged +++ boundary, header cap
guyoron1 Sep 5, 2026
6a92945
docs(review): one disclosure finding per excluded file
guyoron1 Sep 5, 2026
8f796ab
docs(review): make the step 2c filter command runnable as written
guyoron1 Sep 5, 2026
9da767e
chore(lint): raise pr-review context budget to 16815
guyoron1 Sep 5, 2026
7a08cd6
fix(review): classify the forge skills' per-file diff shape; drop the…
guyoron1 Sep 10, 2026
5b2ff12
docs(review): step 2c never clobbers the diff, and an all-excluded PR…
guyoron1 Sep 10, 2026
5585e72
fix(review): dequote quoted ---/+++ paths so GitLab-shaped sections c…
guyoron1 Sep 10, 2026
13dbd27
fix(review): minified and sourcemap rules match case-insensitively li…
guyoron1 Sep 10, 2026
26f194a
docs(review): provenance-warning uses the <pr> file sentinel the agen…
guyoron1 Sep 10, 2026
e3dfd52
chore(lint): raise pr-review context budget to 17579
guyoron1 Sep 10, 2026
fadd993
docs(review): header comment discloses the header-phase buffer cap
guyoron1 Sep 10, 2026
23d3884
fix(review): don't approve a disclosure-only PR to ready-for-merge
guyoron1 Sep 11, 2026
0b7ff4e
fix(review): keep GitLab header-only section's lines through the filter
guyoron1 Sep 11, 2026
67d63be
fix(review): runtime-neutral filter path; shrink skill under budget
guyoron1 Sep 11, 2026
952678f
Merge upstream main into feat/review-diff-filtering
guyoron1 Sep 17, 2026
1d147cf
Merge upstream main into feat/review-diff-filtering
guyoron1 Sep 21, 2026
d618310
fix(review): a newline in a filename cannot forge a "### File:" secti…
guyoron1 Sep 21, 2026
58cbe4b
fix(review): migrations exemption and vendored rule match case-insens…
guyoron1 Sep 21, 2026
17d3aaf
Merge upstream main into feat/review-diff-filtering
guyoron1 Sep 24, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ script-test:
$(call run-timed,bash eval/scripts/scrub-eval-results-test.sh)
$(call run-timed,bash .github/scripts/check-rollup-result-test.sh)
$(call run-timed,bash .github/scripts/vouch-check-test.sh)
$(call run-timed,bash scripts/filter-review-diff-test.sh)

test: script-test

Expand Down
8 changes: 6 additions & 2 deletions agents/review.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ findings to include. The severity order from lowest to highest is:

Suppress findings below the threshold — do not mention them in the
review body and do not include them in the `findings` array.
Exception: the `provenance-warning` and `excluded-content` process
disclosures are exempt — include them whenever their trigger condition
holds, regardless of the threshold.
Comment thread
qodo-code-review[bot] marked this conversation as resolved.

This filtering applies to the narrative body text and the structured
findings equally. If filtering removes all findings from a
Expand Down Expand Up @@ -168,7 +171,8 @@ file is empty and `PRIOR_REVIEW_PROVENANCE` indicates the failure
reason. Treat this as a first review and include an info-level finding
in the review output: `[provenance-warning]` with the
`PRIOR_REVIEW_PROVENANCE` value and a note that severity anchoring was
skipped for this run. Post-creation edits cannot be reliably attributed
skipped for this run. It is PR-wide, so set `file` to `<pr>` and omit
`line`. Post-creation edits cannot be reliably attributed
to a specific actor.

## Workspace
Expand Down Expand Up @@ -273,7 +277,7 @@ fields such as `outcome`, `summary`, `prior_review_sha`, or
|---------------|---------|----------|-----------------------------------------------|
| `severity` | string | yes | One of: `critical`, `high`, `medium`, `low`, `info` |
| `category` | string | yes | Finding category (min 1 char) |
| `file` | string | yes | File path (min 1 char) |
| `file` | string | yes | File path (min 1 char). Single-valued: a finding about N files is N findings. PR-wide process disclosures that name no file (`provenance-warning`) use the sentinel `<pr>`; `excluded-content` names the one excluded path it discloses |
| `line` | integer | no | Line number (minimum 1) |
| `description` | string | yes | Finding description (min 1 char) |
| `remediation` | string | no | Suggested fix |
Expand Down
Loading
Loading