-
Notifications
You must be signed in to change notification settings - Fork 19
feat(review): filter unreviewable content from diff context #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guyoron1
wants to merge
26
commits into
fullsend-ai:main
Choose a base branch
from
guyoron1:feat/review-diff-filtering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
9a7d116
feat(review): filter unreviewable content from diff context
guyoron1 537480c
fix(review): review round 1 — header-path fallback, bounded buffering…
guyoron1 cdf3674
fix(review): review round 2 — header split, quoted renames, one-line …
guyoron1 9dc7de8
fix(review): review round 3 — src-not-bundle, marker gating, GitLab s…
guyoron1 2775b14
fix(review): review round 4 — info-only disclosure exemption, paired …
guyoron1 951b7a3
docs(review): excluded-content disclosure names all exclusion categories
guyoron1 e388990
fix(review): settle generated markers from the file head, not the hunk
guyoron1 a05fce5
test(review): cover mid-file regen, forged +++ boundary, header cap
guyoron1 6a92945
docs(review): one disclosure finding per excluded file
guyoron1 8f796ab
docs(review): make the step 2c filter command runnable as written
guyoron1 9da767e
chore(lint): raise pr-review context budget to 16815
guyoron1 7a08cd6
fix(review): classify the forge skills' per-file diff shape; drop the…
guyoron1 5b2ff12
docs(review): step 2c never clobbers the diff, and an all-excluded PR…
guyoron1 5585e72
fix(review): dequote quoted ---/+++ paths so GitLab-shaped sections c…
guyoron1 13dbd27
fix(review): minified and sourcemap rules match case-insensitively li…
guyoron1 26f194a
docs(review): provenance-warning uses the <pr> file sentinel the agen…
guyoron1 e3dfd52
chore(lint): raise pr-review context budget to 17579
guyoron1 fadd993
docs(review): header comment discloses the header-phase buffer cap
guyoron1 23d3884
fix(review): don't approve a disclosure-only PR to ready-for-merge
guyoron1 0b7ff4e
fix(review): keep GitLab header-only section's lines through the filter
guyoron1 67d63be
fix(review): runtime-neutral filter path; shrink skill under budget
guyoron1 952678f
Merge upstream main into feat/review-diff-filtering
guyoron1 1d147cf
Merge upstream main into feat/review-diff-filtering
guyoron1 d618310
fix(review): a newline in a filename cannot forge a "### File:" secti…
guyoron1 58cbe4b
fix(review): migrations exemption and vendored rule match case-insens…
guyoron1 17d3aaf
Merge upstream main into feat/review-diff-filtering
guyoron1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.