Skip to content

Remove unsupported hashing methods. - #176

Open
jomunoz wants to merge 1 commit into
fugue:masterfrom
vhl:master
Open

Remove unsupported hashing methods.#176
jomunoz wants to merge 1 commit into
fugue:masterfrom
vhl:master

Conversation

@jomunoz

@jomunoz jomunoz commented Oct 11, 2017

Copy link
Copy Markdown
Contributor

Support of Whirlpool and RIPEMD160 hashing methods was removed in
cryptography.hazmat.primitives.
pyca/cryptography@0d6aaf4

Support of Whirlpool and RIPEMD160 hashing methods was removed in
cryptography.hazmat.primitives.
pyca/cryptography@0d6aaf4
This was referenced Oct 11, 2017
@wayne-luminal

Copy link
Copy Markdown
Contributor

Thanks @jomunoz! I merged and released #174 to get credstash usable again. I'll look at pulling your changes in.

@jomunoz

jomunoz commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

Thanks @wayne-luminal, I think this pr might be the proper solution. In the other solution, by locking to a particular version of the cryptography library, we will be missing bugs fixes that will be made for that library.

@wayne-luminal

Copy link
Copy Markdown
Contributor

@jomunoz You're right. When I looked at both PRs, I see this one is failing but haven't had time to dig into what the issue is yet. I figured to get a workable credstash again I'd add temporarily add the <2.1 to cryptography.

@tomgoren

Copy link
Copy Markdown
Contributor

I guess I duped this without noticing #178 :(

There are some additional bits in my PR that I think might be important.

@ramonamis

Copy link
Copy Markdown

hello! is there any chance this can get released? pinning down the crypto library is not a permanent solution as it breaks other ssl libraries.

@tomgoren

Copy link
Copy Markdown
Contributor

@ramonamis see #178 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants