Update .NET 5.0 to .NET 8.0#269
Closed
Thorium wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hi thanks for working on this. For switching dependencies in another PR it turned out that the project structure needed reworking to disentangle the runtime and design time components, which also ended up with updating the type provider SDK. You were right that the design time needed to keep the netstandard2.0 target or it breaks in fsac. I think this PR has been superseded so I'm closing but thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second stab on @EverybodyKurts PR #261
This time, not .NET7.0 but .NET8.0
I think the main problem with the original PR was that it tried to convert design-time to be a standard 2.1.
It can have multiple targets (here, netstandard2.0 and net8.0), but I think it still must have the old netstandard2.0.