Repository navigation
feat(telemetry): Mail Telemetry Alerts from a template - #41
Merged
Merged
Conversation
An alert mail was its details text and a bare link. It now uses the layout of the Suite emails: a heading for the alert type and state, a box with the node, the opened and resolved times and the details, and a button to the alert. An open Silent Host alert also says to resolve it by hand for a node taken out of service. The template is in templates/operator_emails because these mails go to the Suite Cloud operators, not to a tenant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
templates/operator_emails/telemetry_alert.html, extendstenant_emails/base.html. It sets the heading and message for each alert type (Silent Host, Error Rate) and state (opened, resolved).Alerts.notifyrenders the template and embeds the Suite icon withget_inline_images. The subject does not change.operator_emails/because these mails go to the Suite Cloud operators, not to a tenant.Screenshots
Test plan
test_alerts.pychecks the heading, details, link and icon of the opened mails, and the heading and Resolved row of the resolved mail.checkandformat --checkpass onsuite_cloud/telemetry. The 10 alert tests pass locally on the parent branch, wherealerts.py,test_alerts.pyandemail_types.pyare the same as ondevelop.