Repository navigation
fix(pilot): Serve site embeds from the site origin - #723
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
An HTTPS site can receive an HTTP admin URL for Cloud Settings and fail to load its JavaScript as mixed content. Admin domain changes also make cached embed URLs stale.
Summary
Serve Cloud Settings frontend assets from the site's own
/_pilot/embed/cloud-settings/path. Keep API calls through Frappe and the existing loopback Pilot endpoint.Why
A relative embed URL follows the site's scheme and hostname without depending on the admin domain.
What changed
cloud_settings_embed_url = "/_pilot"; admin renames preserve it while updating dashboard links.Verified with 3,997 passing tests (1 skipped), nginx serving tests, 8 SDK tests, Ruff, and mypy. Deployed to the supplied validation host: Frappe emits relative bundle URLs, nginx serves entries and chunks with the expected cache headers, missing assets return 404, and the site ping succeeds. Public HTTPS browser validation is pending the site's URL.