Skip to content

refactor(bridgert)!: unify bridge naming and extract spawn hooks - #194

Merged
haveyaseen merged 1 commit into
mainfrom
chore/rename-node-to-bridge-2
Aug 23, 2026
Merged

refactor(bridgert)!: unify bridge naming and extract spawn hooks#194
haveyaseen merged 1 commit into
mainfrom
chore/rename-node-to-bridge-2

Conversation

@haveyaseen

Copy link
Copy Markdown
Member

Replace stale node-runtime identifiers with bridge terminology across nodert/bridgert: envBridge* constants, EnvBridgeAttachOnly, ResolveBridgeBinary, bridgeRuntimeErr/bridgeHostErr helpers, and updated sentinel error and log strings. Update compiler and devserver callers to the renamed public API and bridge runtime log lines.

Extract host-adaptive spawn logic into spawn_hooks.go for node, bun, and deno argv prefixing. Add bridge host e2e coverage and compiled-modules integration tests.

BREAKING CHANGE: EnvNodeAttachOnly is renamed to EnvBridgeAttachOnly and ResolveNodeBinary is renamed to ResolveBridgeBinary. Error messages now use the bridge runtime and bridge host prefixes instead of node runtime.

Replace stale node-runtime identifiers with bridge terminology across
`nodert/bridgert`: `envBridge*` constants, `EnvBridgeAttachOnly`,
`ResolveBridgeBinary`, `bridgeRuntimeErr`/`bridgeHostErr` helpers, and updated
sentinel error and log strings. Update compiler and devserver callers to
the renamed public API and bridge runtime log lines.

Extract host-adaptive spawn logic into spawn_hooks.go for node, bun, and
deno argv prefixing. Add bridge host e2e coverage and compiled-modules
integration tests.

BREAKING CHANGE: `EnvNodeAttachOnly` is renamed to `EnvBridgeAttachOnly` and
`ResolveNodeBinary` is renamed to `ResolveBridgeBinary`. Error messages now
use the bridge runtime and bridge host prefixes instead of node runtime.
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@haveyaseen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0bb37f68-039d-4a51-ba4f-099fb605a35c

📥 Commits

Reviewing files that changed from the base of the PR and between 608fb80 and bebd5ad.

📒 Files selected for processing (36)
  • forst/bridgert/bootstrap_socket_test.go
  • forst/bridgert/bridge_host_e2e_test.go
  • forst/bridgert/client.go
  • forst/bridgert/compiled_modules_integration_test.go
  • forst/bridgert/configure.go
  • forst/bridgert/configure_test.go
  • forst/bridgert/errors.go
  • forst/bridgert/errors_format.go
  • forst/bridgert/generator_integration_test.go
  • forst/bridgert/host.go
  • forst/bridgert/host_integration_test.go
  • forst/bridgert/host_invoke_auth_prepare.go
  • forst/bridgert/host_invoke_auth_relay.go
  • forst/bridgert/host_invoke_auth_setup.go
  • forst/bridgert/host_invoke_auth_setup_other.go
  • forst/bridgert/host_invoke_auth_setup_unix.go
  • forst/bridgert/host_lifecycle.go
  • forst/bridgert/host_lifecycle_test.go
  • forst/bridgert/host_worker_test.go
  • forst/bridgert/integration_test.go
  • forst/bridgert/node_interop_modules_test.go
  • forst/bridgert/process.go
  • forst/bridgert/spawn.go
  • forst/bridgert/spawn_hooks.go
  • forst/bridgert/spawn_test.go
  • forst/bridgert/supervisor.go
  • forst/bridgert/supervisor_death_test.go
  • forst/bridgert/supervisor_test.go
  • forst/bridgert/tsx_loader.go
  • forst/internal/compiler/compile_pipeline.go
  • forst/internal/compiler/compile_pipeline_test.go
  • forst/internal/compiler/compiler.go
  • forst/internal/compiler/run_background.go
  • forst/internal/devserver/host_orchestrator.go
  • forst/internal/devserver/host_orchestrator_test.go
  • forst/internal/devserver/watch.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@haveyaseen
haveyaseen merged commit aa23ee0 into main Aug 23, 2026
5 checks passed
@haveyaseen
haveyaseen deleted the chore/rename-node-to-bridge-2 branch August 23, 2026 17:38
@github-actions github-actions Bot mentioned this pull request Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant