refactor(bridgert)!: unify bridge naming and extract spawn hooks - #193
Closed
haveyaseen wants to merge 1 commit into
Closed
refactor(bridgert)!: unify bridge naming and extract spawn hooks#193haveyaseen wants to merge 1 commit into
haveyaseen wants to merge 1 commit into
Conversation
Replace stale node-runtime identifiers with bridge terminology across nodert/bridgert: envBridge* constants, EnvBridgeAttachOnly, ResolveBridgeBinary, bridgeRuntimeErr/bridgeHostErr helpers, and updated sentinel error and log strings. Update compiler and devserver callers to the renamed public API and bridge runtime log lines. Extract host-adaptive spawn logic into spawn_hooks.go for node, bun, and deno argv prefixing. Add bridge host e2e coverage and compiled-modules integration tests. BREAKING CHANGE: EnvNodeAttachOnly is renamed to EnvBridgeAttachOnly and ResolveNodeBinary is renamed to ResolveBridgeBinary. Error messages now use the bridge runtime and bridge host prefixes instead of node runtime.
Contributor
|
Important Review skippedToo many files! This PR contains 432 files, which is 332 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (432)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
haveyaseen
force-pushed
the
chore/rename-node-to-bridge
branch
from
August 23, 2026 16:27
7e01515 to
8b4ed37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace stale node-runtime identifiers with bridge terminology across
nodert/bridgert:envBridge*constants,EnvBridgeAttachOnly,ResolveBridgeBinary,bridgeRuntimeErr/bridgeHostErrhelpers, and updated sentinel error and log strings. Update compiler and devserver callers to the renamed public API and bridge runtime log lines.Extract host-adaptive spawn logic into
spawn_hooks.gofor node, bun, and deno argv prefixing. Add bridge host e2e coverage and compiled-modules integration tests.BREAKING CHANGE:
EnvNodeAttachOnlyis renamed toEnvBridgeAttachOnlyandResolveNodeBinaryis renamed toResolveBridgeBinary. Error messages now use the bridge runtime and bridge host prefixes instead of node runtime.