Repository navigation
docs(skills): name the submission key for an existing Role Assignment - #86
Merged
Merged
Conversation
The formio-actions reference described an `association: "existing"` Role Assignment's target as "a component whose value is the target resource's submission ID". The server reads the target from a component keyed exactly `submission`, so a form whose target field was keyed `user` did not assign the role to the intended user. - formio-actions: the `existing` association is now a configuration checklist: target component keyed exactly `submission`, `settings.role` set explicitly, and `create_all` / `create_own` granted to administrator roles only. SKILL.md and the "Role not being assigned" troubleshooting entry name the key. - formio-resource-planner: template-json.md states the same rules for any `existing` Role Assignment the planner emits. - skill-tests: role-existing-association.test.ts fails any description of the association that omits the `submission` key, and pins the explicit role and administrator-only access guidance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 6 tasks
travist
added a commit
that referenced
this pull request
Oct 4, 2026
…on Packages PR (#87) A push with pending changesets publishes nothing: changesets/action opens or updates the Version Packages PR instead. To build it the action checks out `changeset-release/main` and bumps the versions in the working tree, and leaves the tree there. "Resolve the released @formio/mcp version" then read packages/mcp-server/package.json from that tree, got the next, unpublished version, polled npm for ten minutes and failed the job. #86's run did exactly that for @formio/mcp@0.14.1. #80's run passed only because its changeset bumped @formio/ai alone, leaving the server version unchanged. - The lookup runs only when `steps.changesets.outputs['has-changesets']` is not 'true'. v2 of the action names the output in kebab-case. Every step downstream is already gated on the lookup's version output, so a version run skips them too. - The version and mcpName are read from the pushed commit with `git show "${GITHUB_SHA}:packages/mcp-server/package.json"`, never from the working tree the action leaves behind. - release-waits-for-npm.test.ts pins both. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
formio-actionsreference described the target of anassociation: "existing"Role Assignment as "a component whose value is the target resource's submission ID". The server reads the target from a component keyed exactlysubmission, so a form whose target field was keyeduserdid not assign the role to the intended user (reported by a customer).formio-actions—references/action-types.mdturns theexistingassociation into a configuration checklist: the target component is keyed exactlysubmission,settings.roleis set explicitly, andcreate_all/create_ownin the form'ssubmissionAccessgo to administrator roles only. The settings table,SKILL.md's association note, and the "Role not being assigned" troubleshooting entry name the key.formio-resource-planner—references/template-json.mdstates the same rules for anyexistingRole Assignment the planner emits.skill-tests—role-existing-association.test.tsfails any description of the association that omits thesubmissionkey, and pins the explicit-role and administrator-only access guidance in both references.@formio/ai.Test plan
pnpm test— 1076 skill tests, 1110 server tests passpnpm lintpnpm format🤖 Generated with Claude Code