Repository navigation
Conversation
devantler
marked this pull request as ready for review
October 6, 2026 22:01
Member
|
@devantler can you please rebase and fix the conflicts? Thanks |
Capture directory-scan failures in the parent shell and count incomplete coverage as a validation error. Keep partial discoveries available for validation and preserve NUL-delimited filenames. Add shell regressions to the existing test target. Assisted-by: Codex/gpt-6.1-sol Assisted-by: Claude Code/claude-opus-5-5 Signed-off-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
devantler
force-pushed
the
codex/audit-traversal-544
branch
from
October 10, 2026 10:46
9d966c3 to
155c09c
Compare
Member
|
This is fixed in main |
Author
|
Nice! Recently, or was I using it wrong? |
Author
|
Ah I see #129 Thank you 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Count failed directory traversals as validation errors, including scans that return partial results. Keep validating discovered units while preserving NUL-separated filenames and cleaning up temporary scan storage.
Fixes #133.
Validation:
make test build lintand ShellCheck pass. The shell suite covers all five discovery steps, partial results, positive controls and failure handling. A locally built real backend confirms the unreadable-directory failure and readable ConfigMap control.AI assistance: Codex/gpt-6.1-sol, and Claude Code/claude-opus-5-5 for the rebase. The human author reviewed the contribution and explicitly authorized the DCO sign-off.