Skip to content

Instruct minor release skill to bump source-controller/api everywhere #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matheuscscp merged 1 commit into from
Oct 10, 2026
Merged

Instruct minor release skill to bump source-controller/api everywhere #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions internal/skills/flux-controller-minor-releases/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,18 @@ kustomize-controller, image-automation-controller, and source-watcher). This is
separate follow-up PR per dependent repo, not part of the 11 release steps above.

- Branch from the dependent repo's `main` (which may already carry an earlier
bump from the same release round), then
`go get github.com/fluxcd/<controller>/api@vX.Y.0` followed by `go mod tidy`.
- The bump is usually **`go.mod` + `go.sum` only**. Mirror an existing sibling PR
from the same round for the exact title/body/commit shape.
bump from the same release round).
- The dependency may be imported by **both** modules of a multi-module repo: the
root `go.mod` and the repo's own `api/go.mod`. These are separate Go modules and
must be bumped independently — a single `go get` at the root does **not** update
`api/go.mod`. For each module that actually imports the dependency, run
`go get github.com/fluxcd/<controller>/api@vX.Y.0` followed by `go mod tidy`
**in that module's directory** (root, then `cd api && …`). Check first and skip
a module that does not import it.
- The bump is `go.mod` + `go.sum` — and also `api/go.mod` + `api/go.sum` when the
`api` module imports the dependency. Leaving `api/go.mod` stale is a common
miss. Mirror an existing sibling PR from the same round for the exact
title/body/commit shape.
- **But check whether the dependent repo pins the dependency's published release
manifests** in `config/default/kustomization.yaml` (remote
`…/releases/download/vX.Y.Z/<controller>.crds.yaml` and `.deployment.yaml`
Expand Down
Loading