Update documents and tests - #116
Merged
Merged
Conversation
Runs the import check, websocket smoke suite, and the tests/usage protocol suite on windows-latest for PRs, pushes to master, and manual dispatch. Reuses buildghost-win.yml's private-dep install steps and the lib/x64 -> System32 native-cairo DLL copy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dkdkwizard
force-pushed
the
feature/update-tests-202607
branch
from
July 22, 2026 04:03
617032c to
df5e333
Compare
Commit 29d99d1 swapped os.pipe() for socket.socketpair() in SimulateCamera.__init__ but left fileno()/feed()/close() reading the old _fd_r/_fd_w attributes, so every camera connection against the simulated device crashed with AttributeError and CI's smoke suite failed at camera.frame. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Commit b9bdc87 renamed the DeviceDiscover.try_recive call to try_receive, but CI and all release builds pin fluxclient 2.9.12, which only has the old spelling. Any datagram on the discover socket then raised AttributeError past the OSError-only handler and killed the whole server — CI's usage suite died at the first discover poke. Call whichever spelling exists and broaden the catch so a malformed datagram can never take the server down. Verified against both fluxclient 2.9.12 and 2.10.3 (smoke suite ALL PASS, 39/39 usage tests). Noted the pin mismatch in docs/todo.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Update the pinned refs in ci-tests.yml and all three buildghost workflows so CI and release builds use the same fluxclient the dev environment runs. 2.10.3 has the try_receive rename, so drop the getattr compat shim from the previous commit; keep the broad except so a malformed discover datagram still can't kill the server. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pure document and testing updates analyzed with Claude that saves time for future development.