chore: bump versions for release#889
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the genui, genui_a2a, and a2ui_core packages to version 0.9.0 (0.1.0 for core) across the repository and its examples. Feedback was provided regarding a Dart SDK version mismatch in the verdure example and the manual modification of several platform-specific generated files, which should instead be managed by the Flutter tool through pubspec.yaml and dependency synchronization to ensure consistency and prevent build issues.
| genui: ^0.9.0 | ||
| genui_a2a: ^0.9.0 |
There was a problem hiding this comment.
The genui and genui_a2a packages (now at version 0.9.0) require a minimum Dart SDK version of 3.10.0 (as specified in their respective pubspec.yaml files). However, the environment section of this file (line 13) still specifies sdk: ^3.9.2. This mismatch will cause a version solver error when running flutter pub get. Please update the SDK constraint in the environment section to ">=3.10.0 <4.0.0" to match the requirements of the updated dependencies.
| ) | ||
|
|
||
| list(APPEND FLUTTER_FFI_PLUGIN_LIST | ||
| jni |
There was a problem hiding this comment.
This file is automatically generated by the Flutter tool and should not be modified manually. Manually adding jni to FLUTTER_FFI_PLUGIN_LIST suggests that a required dependency is missing from pubspec.yaml or that the build system is not correctly identifying it. It is recommended to add the necessary package (e.g., package:jni) to your pubspec.yaml so that the Flutter tool can manage the build configuration automatically, ensuring consistency across different development environments.
| func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) { | ||
| AudioplayersDarwinPlugin.register(with: registry.registrar(forPlugin: "AudioplayersDarwinPlugin")) | ||
| FLTFirebaseAppCheckPlugin.register(with: registry.registrar(forPlugin: "FLTFirebaseAppCheckPlugin")) | ||
| FirebaseAppCheckPlugin.register(with: registry.registrar(forPlugin: "FirebaseAppCheckPlugin")) |
There was a problem hiding this comment.
This file is marked as "Generated file. Do not edit." Manual modifications to the plugin registrant are discouraged as they will be overwritten when the Flutter tool regenerates the file (e.g., during flutter pub get or a build). If the plugin class name has changed (e.g., from FLTFirebaseAppCheckPlugin to FirebaseAppCheckPlugin), it is better to resolve this by ensuring that the plugin version and platform-specific configurations (like Podfile.lock) are correctly synchronized using flutter pub get and pod update in the macos directory. Additionally, note the inconsistency with FLTFirebaseCorePlugin on the following line, which further highlights the risk of manual edits.
| FirebaseAppCheckPluginCApiRegisterWithRegistrar( | ||
| registry->GetRegistrarForPlugin("FirebaseAppCheckPluginCApi")); |
There was a problem hiding this comment.
This is a generated file and should not be modified manually. Furthermore, FirebaseAppCheck is being registered before FirebaseCore. In most Firebase integrations, FirebaseCore should be initialized/registered first as other Firebase plugins depend on it. It is recommended to let the Flutter tool generate this file automatically to ensure the correct registration order and maintainability. This also applies to the manual include added on line 10.
| # `a2ui_core` Changelog | ||
|
|
||
| ## 0.0.1 (in progress) | ||
| ## 0.1.0 |
There was a problem hiding this comment.
I do not think we should release this package while we did not resolve the question of technologies: #857 (comment)
Let's keep it 'in progress'.
| description: Core package for A2UI protocol. | ||
| repository: https://github.com/flutter/genui/tree/main/packages/a2ui_core | ||
| version: 0.0.1-dev001 | ||
| version: 0.1.0 |
There was a problem hiding this comment.
let's keep it 'dev': we do not want people to take dependency while the question of technologies is not resolved.
There was a problem hiding this comment.
Created the alternative PR to make things faster: #890
@jacobsimionato, can you review, and, if looks good, merge PR, and release the packages?
2 participants
Description of Changes
This PR prepares the workspace for a new release cycle by bumping package versions and synchronizing their cross-dependencies.
Specifically:
genuito0.9.0.genui_a2ato0.9.0.a2ui_corepackage to0.1.0.CHANGELOG.mdfiles to document the features, fixes, and breaking changes included in these bumps.Rationale
These bumps reflect the latest batch of updates merged into
main, including the structural reorganization that extracted protocol primitives intoa2ui_core, which required a breaking minor version bump for the dependent packages before publishing.Testing/Running Instructions
dart pub getandflutter pub getto ensure all dependencies resolve correctly.cd examples/travel_app && flutter build linux).