vulkan: wait for pending draw to complete before destroying its handles#2046
Open
nJ3ahxac wants to merge 1 commit into
Open
vulkan: wait for pending draw to complete before destroying its handles#2046nJ3ahxac wants to merge 1 commit into
nJ3ahxac wants to merge 1 commit into
Conversation
Fixes a synchronisation issue in shutdown_swapchain_data where vulkan objects were potentially released while in use by the GPU.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a synchronisation issue in shutdown_swapchain_data where vulkan objects were potentially released while in use by the GPU.
I had a strange issue earlier this month when opening the HUD would cause a crash. I created an issue for it in #2011. It was really hard to reproduce and I thought it was caused by validation warnings that were fixed in later versions - unfortunately ran into the issue again just now.
I had a look into it and found a synchronisation issue. There may be more lurking around - I suspect there are many in vkBasalt as well (which is unmaintained!).