feat: add a set-fps-limit control command#1969
Open
farnoy wants to merge 1 commit into
Open
Conversation
Preserve control socket if the reloaded config does not change its path. This lets clients keep the connection across preset changes or config reloads. Update the fps_limiter to directly store the current target, supporting runtime values.
Owner
|
The main reason I’m hesitant to merge this right now is that we’re in the middle of a fairly major architectural shift toward a client/server model, and this change likely wouldn’t be trivially portable to that design. One option might be to target this toward the server2 branch instead, where most of that work is happening, but I’d like to hear your thoughts first. If it helps, I’m also happy to talk through how this could fit into the new design, either here in the PR or on Discord, whichever you prefer. |
Author
|
I can rework/retarget the change if needed. What's the timeline on server2 and are there any docs on what's changing? I could just wait until you're ready to promote server2 as 0.9 or the new mainline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve control socket if the reloaded config does not change its path. This lets clients keep the connection across preset changes or config reloads.
Update the fps_limiter to directly store the current target, supporting runtime values.
I want to upstream this for use in mangochill