fix: defensive hardening across SkyAware frontend - #312
Open
zagers wants to merge 1 commit into
Open
Conversation
- restrictUrlRequest: add isFinite check to prevent NaN in localStorage - flag_image: validate filename pattern before setting img src - altitude cell: use DOM manipulation instead of innerHTML Fixes flightaware#310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grouped low-severity defensive fixes across the SkyAware frontend for security hardening.
Changes
script.js:restrictUrlRequest— addisFinite()check to preventNaNfrom being stored inlocalStoragescript.js:flag_image— validate filename pattern (/^[a-zA-Z0-9_-]+\.png$/) before settingimg src, preventing path traversal if data source changesscript.js: Altitude table cell — use DOM manipulation (createElement/textContent) instead ofinnerHTMLformatter.js: Addformat_altitude_text()andformat_vert_rate_triangle()helpers that return plain text without HTMLDeferred
Fixes #310