fix: check realloc return value in generateAircraftJson - #307
Open
zagers wants to merge 1 commit into
Open
Conversation
If realloc fails due to OOM, the code would dereference NULL. Now saves the old buffer pointer and frees it on failure, returning NULL to the caller. Fixes flightaware#305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks the return value of
reallocingenerateAircraftJsonto prevent a NULL pointer dereference on out-of-memory conditions.Changes
net_io.c: Save the old buffer pointer beforerealloc. Ifreallocreturns NULL, free the old buffer and return NULL to the caller instead of crashing.Motivation
When the JSON output buffer needs to grow, the code called
reallocwithout checking the return value. If memory is exhausted,reallocreturns NULL and the subsequent pointer assignments cause a segfault. This is more likely on memory-constrained devices or when tracking a very large number of aircraft.Fixes #305