fix: add NULL checks after strtok in handleFaupCommand - #306
Open
zagers wants to merge 1 commit into
Open
Conversation
A client sending a field name without a value (e.g. 'upload_rate_multiplier\t') caused strtok to return NULL, which was passed to atof/atoi, crashing the process. Fixes flightaware#302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds NULL checks after
strtok(NULL, "\t")calls inhandleFaupCommandto prevent a crash when a client sends a field name without a corresponding value.Changes
net_io.c: Addedif (msg_field == NULL) break;after eachstrtokcall that retrieves a value forupload_rate_multiplierandupload_unknown_commbMotivation
A client connecting to the FAUP command port can send
upload_rate_multiplier\t(with tab but no value). Thestrtokcall returns NULL, which is passed toatof(), causing undefined behavior (typically a segfault).Fixes #302