fix: replace sprintf with safe_snprintf in SBS output - #301
Open
zagers wants to merge 1 commit into
Open
Conversation
The SBS output function used unbounded sprintf into a fixed 200-byte buffer. Replace all sprintf calls with safe_snprintf which respects the buffer end pointer, preventing potential buffer overflow. Fixes flightaware#297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all unbounded
sprintfcalls withsafe_snprintfin the SBS output function to prevent potential buffer overflow.Changes
net_io.c: Insend_sbs_message(), replaced 20+sprintfcalls withsafe_snprintf(p, end, ...)which respects the buffer boundaryendpointer computed from the 200-byte buffer allocationMotivation
The SBS output function prepared a 200-byte buffer via
prepareWrite()but usedsprintfwhich has no bounds checking. While the SBS message format is relatively fixed-length,safe_snprintfis the pattern used throughout the rest of the codebase and provides defense-in-depth against unexpected field lengths.Fixes #297