fix: add --max-clients option to limit concurrent network connections - #300
Open
zagers wants to merge 1 commit into
Open
fix: add --max-clients option to limit concurrent network connections#300zagers wants to merge 1 commit into
zagers wants to merge 1 commit into
Conversation
Prevents resource exhaustion DoS by allowing a configurable limit on the number of simultaneous TCP clients. Connections are rejected when the limit is reached. Fixes flightaware#298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable
--max-clientsoption to limit the number of simultaneous TCP clients connecting to dump1090.Changes
dump1090.h: Addedmax_clientsandclient_countfields to the Modes structdump1090.c: Added--max-clients <n>CLI option parsing and help textnet_io.c:Modes.client_countmodesAcceptClients()whenModes.client_count >= Modes.max_clientsUsage
Default is
0(unlimited), preserving backward compatibility.Motivation
Without a connection limit, an attacker can open thousands of TCP connections, exhausting memory and file descriptors. Each connection consumes ~1KB of memory and is polled on every network cycle, causing CPU degradation and service unavailability.
Fixes #298