feat: Implement TertiaryTapCallbacks on new event system#3899
Open
luanpotter wants to merge 1 commit intomainfrom
Open
feat: Implement TertiaryTapCallbacks on new event system#3899luanpotter wants to merge 1 commit intomainfrom
luanpotter wants to merge 1 commit intomainfrom
Conversation
8895f2c to
e02a927
Compare
007a76c to
72bda77
Compare
luanpotter
commented
May 1, 2026
| @@ -21,29 +21,53 @@ class SecondaryTapDispatcherKey implements ComponentKey { | |||
| /// automatically whenever any [SecondaryTapCallbacks] are mounted into the | |||
| /// component tree. | |||
| class SecondaryTapDispatcher extends Dispatcher<FlameGame> { | |||
Member
Author
There was a problem hiding this comment.
NOTE: on my consideration around whether to rename this
while it is public, it is not really user facing - I think renaming is totally fine
problem is that it is hard to name because flutter splits primary taps as a completely different recognizer
that means we have (currently) MultiTapDispatcher (for primary)
and this for secondary + tertiary
NonPrimaryTapDispatcher is the best I came up with but isn't perfect
thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following up on our events master plan.
This adds
TertiaryTapCallbacksand necessary infrastructure to make it work.This replaces the old
TertiaryTapDetector(which we can deprecate later), e.g.:With
TertiaryTapCallbacksfollowing the newer patterns in flame:Note that this new detector uses the same dispatcher as secondary, as they share the same underlying flutter recognizer. This is in line with my refactor on #3900 - basically we allow for multiple callbacks to register the same detector, handling deduplication and bindings.
Also adds example, tests, and documentation.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?