refactor(sdk): the RFC 8785 rule lives in internal/canonicaljson - #71
Merged
Merged
Conversation
sdk.CanonicalJSON keeps its signature and ErrInvalidJSON its identity; the transform, the escaped-lone-surrogate check and the hex parser move to internal/canonicaljson so a package that must not import the SDK can canonicalize under the same rule. Behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdk.CanonicalJSONkeeps its signature andErrInvalidJSONkeeps its identity. The RFC 8785 transform, the escaped-lone-surrogate check and the hex parser move tointernal/canonicaljson, so other packages of the module can canonicalize under the same rule without importingsdk. No behaviour change; the existingsdktests cover the moved code throughCanonicalJSON.Test plan
go build ./...go test ./sdk/ ./internal/...golangci-lint run ./sdk/... ./internal/...reports 0 issues