Repository navigation
add return after pasting option - #162
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Configure and expose the option iosfrontend/iosfrontend.h, common/runtime-api.h, common/runtime_keyboard.cpp, po/zh_CN.po |
The clipboard configuration adds a disabled-by-default option. The frontend and runtime API expose its value. A Simplified Chinese translation is added. |
Apply the option after clipboard commits uipanel/Clipboard.swift |
After committing an entry’s text, commitEntry() pops the display mode when the option is enabled. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant Clipboard
participant RuntimeAPI
participant FcitxBridge as with_fcitx
participant IosFrontend
participant ViewModel
Clipboard->>Clipboard: Commit entry text
Clipboard->>RuntimeAPI: isClipboardReturnAfterPasteEnabled()
RuntimeAPI->>FcitxBridge: Read frontend option
FcitxBridge->>IosFrontend: returnAfterPaste()
IosFrontend-->>FcitxBridge: Configured option value
FcitxBridge-->>RuntimeAPI: Option value
RuntimeAPI-->>Clipboard: Enabled or disabled
opt Option is enabled
Clipboard->>ViewModel: popDisplayMode()
end
Possibly related PRs
- fcitx-contrib/fcitx5-ios#158: Adds the nested clipboard configuration that PR
#162extends. - fcitx-contrib/fcitx5-ios#159: Adds
HistoryLimitto the same configuration that PR#162extends.
Merge Risk: 
4f004
-
The option is correctly wired and limited to clipboard-history activation; the change is ready to merge after normal interaction validation.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: adding a return-after-pasting option. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 4 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
IPA comparisonNo difference. |
Add a disabled-by-default "Return after pasting" clipboard option, placed after the history limit and before tracking-parameter removal. When enabled, pasting a history entry uses the existing return action to restore the previous keyboard layout.
Validated with an arm64 simulator build and code signing, format/lint checks, and settings-page checks for Chinese localization, ordering and the default value. The paste-and-return interaction was not manually verified because the temporary simulator did not load the keyboard extension.
Summary by CodeRabbit