[compiler] Fix false positive for local mutation in filter callbacks#36269
Open
soloclz wants to merge 1 commit intofacebook:mainfrom
Open
[compiler] Fix false positive for local mutation in filter callbacks#36269soloclz wants to merge 1 commit intofacebook:mainfrom
soloclz wants to merge 1 commit intofacebook:mainfrom
Conversation
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This narrows the fix for
ValidateLocalsNotReassignedAfterRenderto the behavior that actually resolves the false positive.The validation now gives
PropertyLoadits own non-propagating case, which stops reassignment metadata from flowing from values likesomeItemsinto derived property loads likesomeItems.length. That is enough to avoid incorrectly treating synchronous render-time array callbacks such asfilterandmapas post-render escapes.This PR also keeps the regression coverage in the TypeScript eslint-plugin-react-hooks tests for the
filterandmaprepros, withforEachleft in place as an adjacent non-regression case.Related to #31569
How did you test this change?
yarn workspace babel-plugin-react-compiler buildyarn workspace babel-plugin-react-compiler lint src/Validation/ValidateLocalsNotReassignedAfterRender.tsnode ./scripts/jest/jest-cli.js --runTestsByPath packages/eslint-plugin-react-hooks/__tests__/ReactCompilerRuleTypescript-test.ts --runInBand