Skip to content

Document coverage exclusion - #3424

Open
Meakk wants to merge 2 commits into
f3d-app:masterfrom
Meakk:coverage-doc
Open

Document coverage exclusion#3424
Meakk wants to merge 2 commits into
f3d-app:masterfrom
Meakk:coverage-doc

Conversation

@Meakk

@Meakk Meakk commented Jul 29, 2026

Copy link
Copy Markdown
Member

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I have not used AI to generate any of the content of this pull request
  • I have used AI to generate code in this pull request:
    • I have carefully read and understood the AI policy.
    • I have carefully reviewed and completely understood every generated line.
    • I disclose below which parts of the code were generated and with which AI model:

...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Meakk Meakk self-assigned this Jul 29, 2026
@Meakk
Meakk marked this pull request as ready for review July 29, 2026 09:11
@Meakk
Meakk requested a review from a team as a code owner July 29, 2026 09:11
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (0d0feb8) to head (31b8080).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3424      +/-   ##
==========================================
+ Coverage   97.06%   97.16%   +0.09%     
==========================================
  Files         216      216              
  Lines       18784    18762      -22     
==========================================
- Hits        18233    18230       -3     
+ Misses        551      532      -19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal

Copy link
Copy Markdown
Member

There are many other place where this should be put, do you plan to do it in another PR ?

@Meakk

Meakk commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

There are many other place where this should be put, do you plan to do it in another PR ?

Ideally at some point, but I wanted to add the documentation and some examples in the code.
Determining if an uncovered line is a miss or unreachable will take time.

@mwestphal

Copy link
Copy Markdown
Member

There are many other place where this should be put, do you plan to do it in another PR ?

Ideally at some point, but I wanted to add the documentation and some examples in the code. Determining if an uncovered line is a miss or unreachable will take time.

Thats fair.

@Meakk

Meakk commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

0.1% coverage increase, what a PR!

Comment thread CONTRIBUTING.md Outdated
Comment thread library/src/engine.cxx
if (!clip::get_text(content))
{
// Unreachable in testing
// LCOV_EXCL_START

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noclone can you remind me why these lines couldn't be covered?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it only happens in case of clipboard manager failure, which we can't produce in the CI

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it can fail in real use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants