Document coverage exclusion - #3424
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3424 +/- ##
==========================================
+ Coverage 97.06% 97.16% +0.09%
==========================================
Files 216 216
Lines 18784 18762 -22
==========================================
- Hits 18233 18230 -3
+ Misses 551 532 -19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
There are many other place where this should be put, do you plan to do it in another PR ? |
Ideally at some point, but I wanted to add the documentation and some examples in the code. |
Thats fair. |
|
0.1% coverage increase, what a PR! |
| if (!clip::get_text(content)) | ||
| { | ||
| // Unreachable in testing | ||
| // LCOV_EXCL_START |
There was a problem hiding this comment.
@noclone can you remind me why these lines couldn't be covered?
There was a problem hiding this comment.
it only happens in case of clipboard manager failure, which we can't produce in the CI
There was a problem hiding this comment.
but it can fail in real use case?
Describe your changes
Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
...
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.